Skip to content

feat: add Char::length method and rename Char::utf16_len #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: add Char::length method and rename Char::utf16_len #2861

wants to merge 1 commit into from
+41 −1

Conversation

@Asterless
Copy link
Contributor

@Asterless Asterless commented Oct 27, 2025 •
edited
Loading

Based on #2856.
Renaming Char::utf16_len to Char::length will no longer cause confusion when using String::length and Char::length.And the Char::char_length will always return 1.

@Asterless Asterless changed the title feat: add Char::length method and deprecate Char::utf16_len feat: add Char::length method and rename Char::utf16_len Oct 27, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1622

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 89.854%
Totals Coverage Status
Change from base Build 1621: 0.001%
Covered Lines: 9786
Relevant Lines: 10891
💛 - Coveralls

@Asterless Asterless deleted the Feat/char_length branch October 28, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Asterless @coveralls @peter-jerry-ye